NFS: Use kcalloc() when allocating arrays
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 20 Jan 2012 23:57:02 +0000 (18:57 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Sep 2012 02:36:48 +0000 (03:36 +0100)
commit 7d9dea915fe333357912bce2d624ee848dfbd890 upstream.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfs/blocklayout/extents.c
fs/nfs/pnfs.c

index c69682a..4e2ee99 100644 (file)
@@ -153,7 +153,7 @@ static int _preload_range(struct pnfs_inval_markings *marks,
        count = (int)(end - start) / (int)tree->mtt_step_size;
 
        /* Pre-malloc what memory we might need */
-       storage = kmalloc(sizeof(*storage) * count, GFP_NOFS);
+       storage = kcalloc(count, sizeof(*storage), GFP_NOFS);
        if (!storage)
                return -ENOMEM;
        for (i = 0; i < count; i++) {
index f881a63..4dfc3f1 100644 (file)
@@ -590,7 +590,7 @@ send_layoutget(struct pnfs_layout_hdr *lo,
        max_resp_sz = server->nfs_client->cl_session->fc_attrs.max_resp_sz;
        max_pages = max_resp_sz >> PAGE_SHIFT;
 
-       pages = kzalloc(max_pages * sizeof(struct page *), gfp_flags);
+       pages = kcalloc(max_pages, sizeof(struct page *), gfp_flags);
        if (!pages)
                goto out_err_free;