sched: declare pid_alive as inline
authorRichard Guy Briggs <rgb@redhat.com>
Sun, 16 Mar 2014 18:00:19 +0000 (14:00 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 17 Nov 2015 15:54:45 +0000 (15:54 +0000)
commit 80e0b6e8a001361316a2d62b748fe677ec46b860 upstream.

We accidentally declared pid_alive without any extern/inline connotation.
Some platforms were fine with this, some like ia64 and mips were very angry.
If the function is inline, the prototype should be inline!

on ia64:
include/linux/sched.h:1718: warning: 'pid_alive' declared inline after
being called

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Neal Gompa <ngompa13@gmail.com>
include/linux/sched.h

index 44e5f47..9b9ac29 100644 (file)
@@ -1690,7 +1690,7 @@ static inline pid_t task_tgid_vnr(struct task_struct *tsk)
 }
 
 
-static int pid_alive(const struct task_struct *p);
+static inline int pid_alive(const struct task_struct *p);
 static inline pid_t task_ppid_nr_ns(const struct task_struct *tsk, struct pid_namespace *ns)
 {
        pid_t pid = 0;