l2tp: purge session reorder queue on delete
authorTom Parkin <tparkin@katalix.com>
Tue, 19 Mar 2013 06:11:20 +0000 (06:11 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Feb 2018 18:32:11 +0000 (18:32 +0000)
commit 4c6e2fd35460208596fa099ee0750a4b0438aa5c upstream.

Add calls to l2tp_session_queue_purge as a part of l2tp_tunnel_closeall
and l2tp_session_delete.  Pseudowire implementations which are deleted only
via. l2tp_core l2tp_session_delete calls can dispense with their own code for
flushing the reorder queue.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/l2tp/l2tp_core.c

index 4b727a6..c732a58 100644 (file)
@@ -1347,6 +1347,8 @@ again:
                                synchronize_rcu();
                        }
 
+                       l2tp_session_queue_purge(session);
+
                        if (session->session_close != NULL)
                                (*session->session_close)(session);
 
@@ -1669,6 +1671,8 @@ EXPORT_SYMBOL_GPL(l2tp_session_free);
  */
 int l2tp_session_delete(struct l2tp_session *session)
 {
+       l2tp_session_queue_purge(session);
+
        if (session->session_close != NULL)
                (*session->session_close)(session);