media: bt8xx: Fix err 'bt878_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 21 Sep 2017 23:23:56 +0000 (19:23 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:05 +0000 (00:30 +0100)
commit 45392ff6881dbe56d41ef0b17c2e576065f8ffa1 upstream.

This is odd to call 'pci_disable_device()' in an error path before a
coresponding successful 'pci_enable_device()'.

Return directly instead.

Fixes: 77e0be12100a ("V4L/DVB (4176): Bug-fix: Fix memory overflow")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/dvb/bt8xx/bt878.c

index b34fa95..db53824 100644 (file)
@@ -434,8 +434,7 @@ static int __devinit bt878_probe(struct pci_dev *dev,
               bt878_num);
        if (bt878_num >= BT878_MAX) {
                printk(KERN_ERR "bt878: Too many devices inserted\n");
-               result = -ENOMEM;
-               goto fail0;
+               return -ENOMEM;
        }
        if (pci_enable_device(dev))
                return -EIO;