gpu: pvr: kick: check for duplicate src syncs When duplicate syncs are present, we deadlock; so check and throw an error message. Was already fixed in userspace as part of #253237, this now shores up the kernel too. Fixes: NB#254225 Signed-off-by: Luc Verhaegen <libv@codethink.co.uk>
gpu: pvr: fix missing return value warning when CONFIG_BUG=n Although the behaviour after these functions return in a BUG() condition is undefined, we could still make things somewhat more predictable by returning the same value every time. Also this way we get rid of the warning. Signed-off-by: Imre Deak <imre.deak@nokia.com>
gpu: pvr: hwrec: fix hwrec_mem_pages type change warnings Last minute change of hwrec_mem_pages, from u32 to unsigned long, was not build tested due to hwrec_mem dumping now only happening inside CONFIG_PVR_DEBUG, which was not given a spin before submission. Signed-off-by: Luc Verhaegen <libv@codethink.co.uk> Signed-off-by: Imre Deak <imre.deak@nokia.com>
gpu: pvr: move pdump ioctls to its own range at 192 This removes the shifting of ioctls when enabling pdump builds. Fixes: NB#247418 - PVR kernel driver IOCTL IDs depend on build configuration Signed-off-by: Luc Verhaegen <libv@codethink.co.uk> Signed-off-by: Imre Deak <imre.deak@nokia.com>
gpu: pvr: fix init script handling for pdump/non-pdump A PDUMP enabled build has SGX_INIT_OP_HALT shift one up in the enum, as its former position is replaced with SGX_INIT_OP_PDUMP_HW_REG. When kernel and userspace are out of sync, this leads to rather interesting results since the init script is run _before_ userspace build options are compared with the kernel build options. By moving SGX_INIT_OP_PDUMP_HW_REG, and not masking it behind #ifdef PDUMP, we get around this issue for good, without in anyway altering the behavior of a current non-pdump build. Some extra checking of the init script is now also included to catch and warn about all possible cases of kernel and userspace being out of sync, with respect to pdump support (and the new difference in OP_PDUMP_HW_REG). This way, even if we do not make it to the build option checking, we still know what went wrong. This patch requires matching userspace, but only when pdump is enabled. Signed-off-by: Luc Verhaegen <libv@codethink.co.uk> Signed-off-by: Imre Deak <imre.deak@nokia.com>