usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Mon, 25 May 2020 11:39:52 +0000 (13:39 +0200)
committerMatthias Brugger <mbrugger@suse.com>
Thu, 9 Jul 2020 13:46:12 +0000 (15:46 +0200)
commit8e2ab05000ab91daea63022665d2b0c86f5cba3c
treea4537a3fa32a7f818fe4226a7186c0b72773cb5a
parent61293f519ef75b3ead00a083f65811df31692b9d
usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

There might be hardware configurations where 64-bit data accesses
to XHCI registers are not supported properly.  This patch removes
the readq/writeq so always two 32-bit accesses are used to read/write
64-bit XHCI registers, similarly as it is done in Linux kernel.

This patch fixes operation of the XHCI controller on RPI4 Broadcom
BCM2711 SoC based board, where the VL805 USB XHCI controller is
connected to the PCIe Root Complex, which is attached to the system
through the SCB bridge.

Even though the architecture is 64-bit the PCIe BAR is 32-bit and likely
the 64-bit wide register accesses initiated by the CPU are not properly
translated to a sequence of 32-bit PCIe accesses.
xhci_readq(), for example, always returns same value in upper and lower
32-bits, e.g. 0xabcd1234abcd1234 instead of 0x00000000abcd1234.

Cc: Sergey Temerkhanov <s.temerkhanov@gmail.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
include/usb/xhci.h