cap_syslog: accept CAP_SYS_ADMIN for now
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 11 Feb 2011 01:53:55 +0000 (17:53 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 11 Feb 2011 01:53:55 +0000 (17:53 -0800)
commitee24aebffb75a7f940cf52c8cf6910947b3130c0
treeed1eafa8b1a30b078c9fa680aafbb49632921a0d
parent67d019528e5c2693145217cf18a507689980d2a4
cap_syslog: accept CAP_SYS_ADMIN for now

In commit ce6ada35bdf7 ("security: Define CAP_SYSLOG") Serge Hallyn
introduced CAP_SYSLOG, but broke backwards compatibility by no longer
accepting CAP_SYS_ADMIN as an override (it would cause a warning and
then reject the operation).

Re-instate CAP_SYS_ADMIN - but keeping the warning - as an acceptable
capability until any legacy applications have been updated.  There are
apparently applications out there that drop all capabilities except for
CAP_SYS_ADMIN in order to access the syslog.

(This is a re-implementation of a patch by Serge, cleaning the logic up
and making the code more readable)

Acked-by: Serge Hallyn <serge@hallyn.com>
Reviewed-by: James Morris <jmorris@namei.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/printk.c