sysfs: handle failure path correctly for readdir()
authorMing Lei <ming.lei@canonical.com>
Wed, 20 Mar 2013 15:25:25 +0000 (23:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 23:53:42 +0000 (16:53 -0700)
commite5110f411d2ee35bf8d202ccca2e89c633060dca
tree9fe7297901679cca05b459f9e7e524e99c534a7d
parent991f76f837bf22c5bb07261cfd86525a0a96650c
sysfs: handle failure path correctly for readdir()

In case of 'if (filp->f_pos ==  0 or 1)' of sysfs_readdir(),
the failure from filldir() isn't handled, and the reference counter
of the sysfs_dirent object pointed by filp->private_data will be
released without clearing filp->private_data, so use after free
bug will be triggered later.

This patch returns immeadiately under the situation for fixing the bug,
and it is reasonable to return from readdir() when filldir() fails.

Reported-by: Dave Jones <davej@redhat.com>
Tested-by: Sasha Levin <levinsasha928@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/dir.c