git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 424d54d) | patch
can: c_can: precedence error in c_can_chip_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 15 Jun 2012 00:20:44 +0000 (00:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Jun 2012 22:25:56 +0000 (15:25 -0700)
commitd9cb9bd63eb27ac19f26a8547128c053f43a5da8
treeddba8269435dd7fda01dcc59574ec474a02173a7tree | snapshot
parent424d54d2dca03805942055e5b19926d33a7d1e31commit | diff
can: c_can: precedence error in c_can_chip_config()

(CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
is zero so the condition is never true.  The intent here was to test
that both flags were set.

Cc: <stable@kernel.org> # 2.6.39+
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/c_can/c_can.c diff | blob | history
Pandora Kernel Repository