iommu/vt-d: Fix an off-by-one bug in __domain_mapping()
authorJiang Liu <jiang.liu@linux.intel.com>
Wed, 26 Nov 2014 01:42:10 +0000 (09:42 +0800)
committerJoerg Roedel <jroedel@suse.de>
Tue, 2 Dec 2014 12:03:09 +0000 (13:03 +0100)
commitcc4f14aa170d895c9a43bdb56f62070c8a6da908
treeaa8e7d2d6634e0713a9773a77659759f16d967cd
parent864b94adfcba752aa902ee34497bbe58b97aa8d3
iommu/vt-d: Fix an off-by-one bug in __domain_mapping()

There's an off-by-one bug in function __domain_mapping(), which may
trigger the BUG_ON(nr_pages < lvl_pages) when
(nr_pages + 1) & superpage_mask == 0

The issue was introduced by commit 9051aa0268dc "intel-iommu: Combine
domain_pfn_mapping() and domain_sg_mapping()", which sets sg_res to
"nr_pages + 1" to avoid some of the 'sg_res==0' code paths.

It's safe to remove extra "+1" because sg_res is only used to calculate
page size now.

Reported-And-Tested-by: Sudeep Dutt <sudeep.dutt@intel.com>
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: <stable@vger.kernel.org> # >= 3.0
Acked-By: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel-iommu.c