KEYS: special dot prefixed keyring name bug fix
authorMimi Zohar <zohar@linux.vnet.ibm.com>
Thu, 22 May 2014 18:02:23 +0000 (14:02 -0400)
committerMimi Zohar <zohar@linux.vnet.ibm.com>
Thu, 17 Jul 2014 13:35:14 +0000 (09:35 -0400)
commita4e3b8d79a5c6d40f4a9703abf7fe3abcc6c3b8d
treec8b4b4458f2f213bddff67cb347f732836629e97
parent32c2e6752ff0f48fe03b9e1c7c64bde580a840d2
KEYS: special dot prefixed keyring name bug fix

Dot prefixed keyring names are supposed to be reserved for the
kernel, but add_key() calls key_get_type_from_user(), which
incorrectly verifies the 'type' field, not the 'description' field.
This patch verifies the 'description' field isn't dot prefixed,
when creating a new keyring, and removes the dot prefix test in
key_get_type_from_user().

Changelog v6:
- whitespace and other cleanup

Changelog v5:
- Only prevent userspace from creating a dot prefixed keyring, not
  regular keys  - Dmitry

Reported-by: Dmitry Kasatkin <d.kasatkin@samsung.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
security/keys/keyctl.c