USB: OHCI: workaround for hardware bug: retired TDs not added to the Done Queue
authorAlan Stern <stern@rowland.harvard.edu>
Mon, 26 Nov 2012 17:36:21 +0000 (12:36 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Nov 2012 22:57:20 +0000 (14:57 -0800)
commit50ce5c0683aa83eb161624ea89daa5a9eee0c2ce
tree52289863b53a3c1c7e911089db7094920c41f16a
parent31b6a1048b7292efff8b5b53ae3d9d29adde385e
USB: OHCI: workaround for hardware bug: retired TDs not added to the Done Queue

This patch (as1636) is a partial workaround for a hardware bug
affecting OHCI controllers by NVIDIA at least, maybe others too.  When
the controller retires a Transfer Descriptor, it is supposed to add
the TD onto the Done Queue.  But sometimes this doesn't happen, with
the result that ohci-hcd never realizes the corresponding transfer has
finished.  Symptoms can vary; a typical result is that USB audio stops
working after a while.

The patch works around the problem by recognizing that TDs are always
processed in order.  Therefore, if a later TD is found on the Done
Queue than all the earlier TDs for the same endpoint must be finished
as well.

Unfortunately this won't solve the problem in cases where the missing
TD is the last one in the endpoint's queue.  A complete fix would
require a signficant amount of change to the driver.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Oliver Neukum <oneukum@suse.de>
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-q.c