posix_acl: handle NULL ACL in posix_acl_equiv_mode
authorChristoph Hellwig <hch@lst.de>
Sun, 4 May 2014 11:03:32 +0000 (13:03 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 6 May 2014 17:58:42 +0000 (13:58 -0400)
commit50c6e282bdf5e8dabf8d7cf7b162545a55645fd9
treefcfe808968508a7c1aa6e93ded9bc6d3944b6c68
parent60942f2f235ce7b817166cdf355eed729094834d
posix_acl: handle NULL ACL in posix_acl_equiv_mode

Various filesystems don't bother checking for a NULL ACL in
posix_acl_equiv_mode, and thus can dereference a NULL pointer when it
gets passed one. This usually happens from the NFS server, as the ACL tools
never pass a NULL ACL, but instead of one representing the mode bits.

Instead of adding boilerplat to all filesystems put this check into one place,
which will allow us to remove the check from other filesystems as well later
on.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Ben Greear <greearb@candelatech.com>
Reported-by: Marco Munderloh <munderl@tnt.uni-hannover.de>,
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/posix_acl.c