asix: Do full reset during ax88772_bind
authorCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thu, 6 Nov 2014 15:49:41 +0000 (15:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Nov 2014 20:30:03 +0000 (15:30 -0500)
commit436c2a5036b6ffe813310df2cf327d3b69be0734
tree5e50f15284cc6a017b2a3d3bc4ae70bf92063fe6
parent1310b544e5708ab5e4de46e9c70f54b9fd8350b2
asix: Do full reset during ax88772_bind

commit 3cc81d85ee01 ("asix: Don't reset PHY on if_up for ASIX 88772")
causes the ethernet on Arndale to no longer function. This appears to
be because the Arndale ethernet requires a full reset before it will
function correctly, however simply reverting the above patch causes
problems with ethtool settings getting reset.

It seems the problem is that the ethernet is not properly reset during
bind, and indeed the code in ax88772_bind that resets the device is a
very small subset of the actual ax88772_reset function. This patch uses
ax88772_reset in place of the existing reset code in ax88772_bind which
removes some code duplication and fixes the ethernet on Arndale.

It is still possible that the original patch causes some issues with
suspend and resume but that seems like a separate issue and I haven't
had a chance to test that yet.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Tested-by: Riku Voipio <riku.voipio@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix_devices.c