dm raid: ensure superblock's size matches device's logical block size
authorHeinz Mauelshagen <heinzm@redhat.com>
Fri, 17 Oct 2014 11:38:50 +0000 (13:38 +0200)
committerMike Snitzer <snitzer@redhat.com>
Tue, 21 Oct 2014 13:32:15 +0000 (09:32 -0400)
commit40d43c4b4cac4c2647bf07110d7b07d35f399a84
treec26181aac74dff7571e4c444c957ca8a8ccca9ae
parent9d28eb12447ee08bb5d1e8bb3195cf20e1ecd1c0
dm raid: ensure superblock's size matches device's logical block size

The dm-raid superblock (struct dm_raid_superblock) is padded to 512
bytes and that size is being used to read it in from the metadata
device into one preallocated page.

Reading or writing this on a 512-byte sector device works fine but on
a 4096-byte sector device this fails.

Set the dm-raid superblock's size to the logical block size of the
metadata device, because IO at that size is guaranteed too work.  Also
add a size check to avoid silent partial metadata loss in case the
superblock should ever grow past the logical block size or PAGE_SIZE.

[includes pointer math fix from Dan Carpenter]
Reported-by: "Liuhua Wang" <lwang@suse.com>
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-raid.c