ip_forward: Drop frames with attached skb->sk
authorSebastian Pöhn <sebastian.poehn@gmail.com>
Mon, 20 Apr 2015 07:19:20 +0000 (09:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Apr 2015 18:07:33 +0000 (14:07 -0400)
commit2ab957492d13bb819400ac29ae55911d50a82a13
treeb89ecd5aae7568be9843525b174d90180d3166f3
parent04b7fe6a4a231871ef681bc95e08fe66992f7b1f
ip_forward: Drop frames with attached skb->sk

Initial discussion was:
[FYI] xfrm: Don't lookup sk_policy for timewait sockets

Forwarded frames should not have a socket attached. Especially
tw sockets will lead to panics later-on in the stack.

This was observed with TPROXY assigning a tw socket and broken
policy routing (misconfigured). As a result frame enters
forwarding path instead of input. We cannot solve this in
TPROXY as it cannot know that policy routing is broken.

v2:
Remove useless comment

Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_forward.c