USB: serial: fix potential use-after-free after failed probe
authorJohan Hovold <johan@kernel.org>
Wed, 18 Feb 2015 03:34:50 +0000 (10:34 +0700)
committerJohan Hovold <johan@kernel.org>
Thu, 26 Feb 2015 16:08:36 +0000 (17:08 +0100)
commit07fdfc5e9f1c966be8722e8fa927e5ea140df5ce
tree4728261d05363f71ff04ce4defe2f5a37cb0fa67
parent5ee0089b1f7057d8f783db37b2a8116cd114f6e5
USB: serial: fix potential use-after-free after failed probe

Fix return value in probe error path, which could end up returning
success (0) on errors. This could in turn lead to use-after-free or
double free (e.g. in port_remove) when the port device is removed.

Fixes: c706ebdfc895 ("USB: usb-serial: call port_probe and port_remove
at the right times")
Cc: stable <stable@vger.kernel.org> # v2.6.31
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/usb/serial/bus.c