tcm_fc: Fix fc_exch memory leak in ft_send_resp_status
authorNicholas Bellinger <nab@linux-iscsi.org>
Sat, 10 Mar 2012 07:45:38 +0000 (23:45 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 10 Mar 2012 22:42:56 +0000 (14:42 -0800)
commit031ed4d565b31880a4136bb7366bc89f5b1dba7d
treee905871a0c6706ca16f9df33dfaacebbf33a4ca3
parentc7ec05c82bfd6acf1fd800d628591500805f3179
tcm_fc: Fix fc_exch memory leak in ft_send_resp_status

This patch fixes a bug in tcm_fc where fc_exch memory from fc_exch_mgr->ep_pool
is currently being leaked by ft_send_resp_status() usage.  Following current
code in ft_queue_status() response path, using lport->tt.seq_send() needs to be
followed by a lport->tt.exch_done() in order to release fc_exch memory back into
libfc_em kmem_cache.

ft_send_resp_status() code is currently used in pre submit se_cmd ft_send_work()
error exceptions, TM request setup exceptions, and main TM response callback
path in ft_queue_tm_resp().  This bugfix addresses the leak in these cases.

Cc: Mark D Rustad <mark.d.rustad@intel.com>
Cc: Kiran Patil <kiran.patil@intel.com>
Cc: Robert Love <robert.w.love@intel.com>
Cc: Andy Grover <agrover@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/tcm_fc/tfc_cmd.c