From: Julia Lawall Date: Mon, 21 Jul 2008 07:59:15 +0000 (+0200) Subject: [PATCH] ocfs2: Release mutex in error handling code X-Git-Tag: v2.6.27-rc2~96^2 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=commitdiff_plain;h=c259ae52e204d42f8b2d484c85517a4c367030e1;hp=c259ae52e204d42f8b2d484c85517a4c367030e1 [PATCH] ocfs2: Release mutex in error handling code The mutex is released on a successful return, so it would seem that it should be released on an error return as well. The semantic patch finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression l; @@ mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // Signed-off-by: Julia Lawall Signed-off-by: Mark Fasheh ---