From: Takashi Iwai Date: Tue, 10 Jun 2008 15:53:35 +0000 (+0200) Subject: ALSA: hda - Add a warning if pending IRQ is found X-Git-Tag: v2.6.27-rc1~1111^2~96 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=commitdiff_plain;h=a6a950a8a8e1431e8527809339e089ac926a7d34 ALSA: hda - Add a warning if pending IRQ is found The pending IRQ handling is a very hackish workaround and should be avoided as much as possible via a larger bdl_pos_adj option value. Put a warning message if this situation occurs so that the user may have a chance to notice that something is wrong. Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela --- diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 9b2dc0669b94..ec4ae2d94000 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -374,6 +374,7 @@ struct azx { unsigned int single_cmd :1; unsigned int polling_mode :1; unsigned int msi :1; + unsigned int irq_pending_warned :1; /* for debugging */ unsigned int last_cmd; /* last issued command (to sync) */ @@ -1562,6 +1563,14 @@ static void azx_irq_pending_work(struct work_struct *work) struct azx *chip = container_of(work, struct azx, irq_pending_work); int i, pending; + if (!chip->irq_pending_warned) { + printk(KERN_WARNING + "hda-intel: IRQ timing workaround is activated " + "for card #%d. Suggest a bigger bdl_pos_adj.\n", + chip->card->number); + chip->irq_pending_warned = 1; + } + for (;;) { pending = 0; spin_lock_irq(&chip->reg_lock);