From: Kangjie Lu Date: Tue, 3 May 2016 20:44:20 +0000 (-0400) Subject: ALSA: timer: Fix leak in events via snd_timer_user_ccallback X-Git-Tag: v3.2.82~6 X-Git-Url: https://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=commitdiff_plain;h=506a6ad7e521baf8e554eedfd09873f490c8a304;ds=inline ALSA: timer: Fix leak in events via snd_timer_user_ccallback commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 upstream. The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Signed-off-by: Kangjie Lu Signed-off-by: Takashi Iwai Signed-off-by: Ben Hutchings --- diff --git a/sound/core/timer.c b/sound/core/timer.c index b77858f39a38..08a38befe109 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1213,6 +1213,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, tu->tstamp = *tstamp; if ((tu->filter & (1 << event)) == 0 || !tu->tread) return; + memset(&r1, 0, sizeof(r1)); r1.event = event; r1.tstamp = *tstamp; r1.val = resolution;