amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE_ENTRY errors
authorAndreas Herrmann <andreas.herrmann3@amd.com>
Thu, 16 Oct 2008 14:27:36 +0000 (16:27 +0200)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sat, 18 Oct 2008 13:29:30 +0000 (14:29 +0100)
We are on 64-bit so better use u64 instead of u32 to deal with
addresses:

static void __init iommu_set_device_table(struct amd_iommu *iommu)
{
        u64 entry;
  ...
        entry = virt_to_phys(amd_iommu_dev_table);
  ...

(I am wondering why gcc 4.2.x did not warn about the assignment
between u32 and unsigned long.)

Cc: iommu@lists.linux-foundation.org
Cc: stable@kernel.org
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
arch/x86/kernel/amd_iommu_init.c

index 4cd8083..0cdcda3 100644 (file)
@@ -212,7 +212,7 @@ static void __init iommu_set_exclusion_range(struct amd_iommu *iommu)
 /* Programs the physical address of the device table into the IOMMU hardware */
 static void __init iommu_set_device_table(struct amd_iommu *iommu)
 {
-       u32 entry;
+       u64 entry;
 
        BUG_ON(iommu->mmio_base == NULL);