ASoC: fsi: Deletion of unnecessary checks before the function call "clk_disable"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 Dec 2014 13:34:30 +0000 (14:34 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 3 Dec 2014 18:29:04 +0000 (18:29 +0000)
The clk_disable() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/fsi.c

index 66fddec..eefb161 100644 (file)
@@ -842,12 +842,9 @@ static int fsi_clk_disable(struct device *dev,
                return -EINVAL;
 
        if (1 == clock->count--) {
-               if (clock->xck)
-                       clk_disable(clock->xck);
-               if (clock->ick)
-                       clk_disable(clock->ick);
-               if (clock->div)
-                       clk_disable(clock->div);
+               clk_disable(clock->xck);
+               clk_disable(clock->ick);
+               clk_disable(clock->div);
        }
 
        return 0;