md/raid0: apply base queue limits *before* disk_stack_limits
authorNeilBrown <neilb@suse.com>
Thu, 24 Sep 2015 05:47:47 +0000 (15:47 +1000)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 17 Nov 2015 15:54:41 +0000 (15:54 +0000)
commit 66eefe5de11db1e0d8f2edc3880d50e7c36a9d43 upstream.

Calling e.g. blk_queue_max_hw_sectors() after calls to
disk_stack_limits() discards the settings determined by
disk_stack_limits().
So we need to make those calls first.

Fixes: 199dc6ed5179 ("md/raid0: update queue parameter in a safer location.")
Reported-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
[bwh: Backported to 3.2: the code being moved looks a little different]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/raid0.c

index 0abae39..c0b4a21 100644 (file)
@@ -358,16 +358,17 @@ static int raid0_run(struct mddev *mddev)
        }
        conf = mddev->private;
 
-       list_for_each_entry(rdev, &mddev->disks, same_set) {
-               disk_stack_limits(mddev->gendisk, rdev->bdev,
-                                 rdev->data_offset << 9);
-       }
        blk_queue_max_hw_sectors(mddev->queue, mddev->chunk_sectors);
 
        blk_queue_io_min(mddev->queue, mddev->chunk_sectors << 9);
        blk_queue_io_opt(mddev->queue,
                         (mddev->chunk_sectors << 9) * mddev->raid_disks);
 
+       list_for_each_entry(rdev, &mddev->disks, same_set) {
+               disk_stack_limits(mddev->gendisk, rdev->bdev,
+                                 rdev->data_offset << 9);
+       }
+
        /* calculate array device size */
        md_set_array_sectors(mddev, raid0_size(mddev, 0, 0));