mtd: map: Fix compilation warning
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 29 Oct 2012 17:17:26 +0000 (22:47 +0530)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 11 Nov 2017 13:34:46 +0000 (13:34 +0000)
commit 3e9ce49e0ef95e22790a74720f0068696b2477c9 upstream.

This patch is an attempt to fix following compilation warning.

In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0:
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words':
include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I could have used uninitialized_var() too, but didn't used it as the final else
part of map_word_load() is missing. So there is a chance that it might be passed
uninitialized. Better initialize to zero.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/mtd/map.h

index 3887901..ec69d76 100644 (file)
@@ -327,7 +327,7 @@ static inline int map_word_bitsset(struct map_info *map, map_word val1, map_word
 
 static inline map_word map_word_load(struct map_info *map, const void *ptr)
 {
-       map_word r;
+       map_word r = {{0} };
 
        if (map_bankwidth_is_1(map))
                r.x[0] = *(unsigned char *)ptr;