UBI: always warn if case of I/O errors
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Wed, 25 Apr 2012 06:15:38 +0000 (09:15 +0300)
committerGrazvydas Ignotas <notasas@gmail.com>
Thu, 21 Jun 2012 11:46:16 +0000 (14:46 +0300)
Currently UBI silently retries I/O operation in case of errors. This patch
makes it emit a warning before retrying. This should allow users notice issues
earlier.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/io.c

index 9b03f3a..ace4d4c 100644 (file)
@@ -189,9 +189,9 @@ retry:
                }
 
                if (retries++ < UBI_IO_RETRIES) {
-                       dbg_io("error %d%s while reading %d bytes from PEB "
-                              "%d:%d, read only %zd bytes, retry",
-                              err, errstr, len, pnum, offset, read);
+                       ubi_warn("error %d%s while reading %d bytes from PEB "
+                                "%d:%d, read only %zd bytes, retry",
+                                err, errstr, len, pnum, offset, read);
                        yield();
                        goto retry;
                }
@@ -364,8 +364,8 @@ retry:
        err = ubi->mtd->erase(ubi->mtd, &ei);
        if (err) {
                if (retries++ < UBI_IO_RETRIES) {
-                       dbg_io("error %d while erasing PEB %d, retry",
-                              err, pnum);
+                       ubi_warn("error %d while erasing PEB %d, retry",
+                                err, pnum);
                        yield();
                        goto retry;
                }
@@ -383,7 +383,7 @@ retry:
 
        if (ei.state == MTD_ERASE_FAILED) {
                if (retries++ < UBI_IO_RETRIES) {
-                       dbg_io("error while erasing PEB %d, retry", pnum);
+                       ubi_warn("error while erasing PEB %d, retry", pnum);
                        yield();
                        goto retry;
                }