x86: cleanup for setup code crashes during IST probe

Clean up the code for crashes during SpeedStep probing on older
machines.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 9d4b4b4..616b804 100644 (file)
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -24,8 +24,8 @@
 #include <linux/edd.h>
 #include <asm/boot.h>
 #include <asm/setup.h>
 #include <linux/edd.h>
 #include <asm/boot.h>
 #include <asm/setup.h>

-
-#define NCAPINTS   8
+#include "bitops.h"
+#include <asm/cpufeature.h>

 
 /* Useful macros */
 #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))
 
 /* Useful macros */
 #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))

diff --git a/arch/x86/boot/cpu.c b/arch/x86/boot/cpu.c
index 92d6fd7..75298fe 100644 (file)
--- a/arch/x86/boot/cpu.c
+++ b/arch/x86/boot/cpu.c
@@ -16,9 +16,6 @@
  */
 
 #include "boot.h"
  */
 
 #include "boot.h"

-#include "bitops.h"
-#include <asm/cpufeature.h>
-

 #include "cpustr.h"
 
 static char *cpu_name(int level)
 #include "cpustr.h"
 
 static char *cpu_name(int level)

diff --git a/arch/x86/boot/cpucheck.c b/arch/x86/boot/cpucheck.c
index c1ce030..4b9ae7c 100644 (file)
--- a/arch/x86/boot/cpucheck.c
+++ b/arch/x86/boot/cpucheck.c
@@ -22,10 +22,8 @@
 
 #ifdef _SETUP
 # include "boot.h"
 
 #ifdef _SETUP
 # include "boot.h"

-# include "bitops.h"

 #endif
 #include <linux/types.h>
 #endif
 #include <linux/types.h>

-#include <asm/cpufeature.h>

 #include <asm/processor-flags.h>
 #include <asm/required-features.h>
 #include <asm/msr-index.h>
 #include <asm/processor-flags.h>
 #include <asm/required-features.h>
 #include <asm/msr-index.h>

diff --git a/arch/x86/boot/main.c b/arch/x86/boot/main.c
index 01aa64b..197421d 100644 (file)
--- a/arch/x86/boot/main.c
+++ b/arch/x86/boot/main.c
@@ -73,7 +73,8 @@ static void keyboard_set_repeat(void)
  */
 static void query_ist(void)
 {
  */
 static void query_ist(void)
 {

-       /* Some 486 BIOSes apparently crash on this call */
+       /* Some older BIOSes apparently crash on this call, so filter
+          it from machines too old to have SpeedStep at all. */

        if (cpu.level < 6)
                return;
 
        if (cpu.level < 6)
                return;