[POWERPC] Update irq descriptor affinity
authorNathan Fontenot <nfont@austin.ibm.com>
Wed, 6 Feb 2008 20:37:26 +0000 (07:37 +1100)
committerPaul Mackerras <paulus@samba.org>
Thu, 7 Feb 2008 00:40:19 +0000 (11:40 +1100)
The affinity mask in the virq descriptor needs to be set before we
reset the affinity for the virq.  Without doing this the call to get
the new irq server fails and we end up leaving the virq pinned to the
cpu we are removing.

This does not fail the cpu remove from the kernel, but it does prevent
cpu dlpar remove operations from returning the cpu to the hypervisor.

Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/pseries/xics.c

index 8f8dd9c..00e9d29 100644 (file)
@@ -880,8 +880,8 @@ void xics_migrate_irqs_away(void)
                       virq, cpu);
 
                /* Reset affinity to all cpus */
+               irq_desc[virq].affinity = CPU_MASK_ALL;
                desc->chip->set_affinity(virq, CPU_MASK_ALL);
-               irq_desc[irq].affinity = CPU_MASK_ALL;
 unlock:
                spin_unlock_irqrestore(&desc->lock, flags);
        }