x86, relocs: Add jiffies and jiffies_64 to the relative whitelist
authorH. Peter Anvin <hpa@zytor.com>
Thu, 24 May 2012 14:01:38 +0000 (07:01 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:44:10 +0000 (00:44 +0100)
commit ea17e7414bc62e8d3bde8d08e3df1d921c518c17 upstream.

The symbol jiffies is created in the linker script as an alias to
jiffies_64.  Unfortunately this is done outside any section, and
apparently GNU ld 2.21 doesn't carry the section with it, so we end up
with an absolute symbol and therefore a broken kernel.

Add jiffies and jiffies_64 to the whitelist.

The most disturbing bit with this discovery is that it shows that we
have had multiple linker bugs in this area crossing multiple
generations, and have been silently building bad kernels for some time.

Link: http://lkml.kernel.org/r/20120524171604.0d98284f3affc643e9714470@canb.auug.org.au
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/x86/tools/relocs.c

index eb1ad63..e529730 100644 (file)
@@ -70,6 +70,7 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
        "__(start|stop)_notes|"
        "__end_rodata|"
        "__initramfs_start|"
+       "(jiffies|jiffies_64)|"
        "_end)$"
 };