gianfar: Remove unused gfar_add_fcb() function parameter
authorDai Haruki <dai.haruki@freescale.com>
Tue, 16 Dec 2008 23:32:11 +0000 (15:32 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Dec 2008 23:32:11 +0000 (15:32 -0800)
- Also, use cacheable_memzero instead of memset for performance reasons.

Signed-off-by: Dai Haruki <dai.haruki@freescale.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/gianfar.c

index 9057a1d..40756dc 100644 (file)
@@ -1166,11 +1166,11 @@ static int gfar_enet_open(struct net_device *dev)
        return err;
 }
 
-static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb, struct txbd8 *bdp)
+static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb)
 {
        struct txfcb *fcb = (struct txfcb *)skb_push (skb, GMAC_FCB_LEN);
 
-       memset(fcb, 0, GMAC_FCB_LEN);
+       cacheable_memzero(fcb, GMAC_FCB_LEN);
 
        return fcb;
 }
@@ -1233,14 +1233,14 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
        /* Set up checksumming */
        if (CHECKSUM_PARTIAL == skb->ip_summed) {
-               fcb = gfar_add_fcb(skb, txbdp);
+               fcb = gfar_add_fcb(skb);
                status |= TXBD_TOE;
                gfar_tx_checksum(skb, fcb);
        }
 
        if (priv->vlgrp && vlan_tx_tag_present(skb)) {
                if (unlikely(NULL == fcb)) {
-                       fcb = gfar_add_fcb(skb, txbdp);
+                       fcb = gfar_add_fcb(skb);
                        status |= TXBD_TOE;
                }