usb: gadget: function: Fixed the return value on error path
authorPavitrakumar Managutte <pavitra1729@gmail.com>
Wed, 22 Oct 2014 14:03:22 +0000 (19:33 +0530)
committerFelipe Balbi <balbi@ti.com>
Thu, 23 Oct 2014 19:49:35 +0000 (14:49 -0500)
Fixed the return value on failure. status variable
is set to 0 at usb_assign_descriptors call and the same is
returned on error which is incorrect.

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Pavitrakumar Managutte <pavitra1729@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/function/f_rndis.c

index 2f0517f..f13fc6a 100644 (file)
@@ -802,8 +802,10 @@ rndis_bind(struct usb_configuration *c, struct usb_function *f)
 
        if (rndis->manufacturer && rndis->vendorID &&
                        rndis_set_param_vendor(rndis->config, rndis->vendorID,
-                                              rndis->manufacturer))
+                                              rndis->manufacturer)) {
+               status = -EINVAL;
                goto fail_free_descs;
+       }
 
        /* NOTE:  all that is done without knowing or caring about
         * the network link ... which is unavailable to this code