rtlwifi: potential forever loop in rtl92de_hw_init()
authorDan Carpenter <error27@gmail.com>
Wed, 29 Jun 2011 06:31:49 +0000 (09:31 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 29 Jun 2011 19:11:07 +0000 (15:11 -0400)
"i" should be an int here because we are trying to use it to count
to 10000.  The original code looks like it could hang in a forever
loop.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/rtl8192de/hw.c

index 31bdea8..e833bbf 100644 (file)
@@ -908,7 +908,8 @@ int rtl92de_hw_init(struct ieee80211_hw *hw)
        struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
        struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
        bool rtstatus = true;
-       u8 tmp_u1b, i;
+       u8 tmp_u1b;
+       int i;
        int err;
        unsigned long flags;