rapidio/tsi721: Fix interrupt mask when handling MSI
authorBen Hutchings <ben@decadent.org.uk>
Sun, 2 Jun 2013 02:34:36 +0000 (03:34 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 19 Jun 2013 01:16:38 +0000 (02:16 +0100)
Commit 1619f441963e 'rapidio/tsi721: fix bug in MSI interrupt
handling' (commit 1ccc819da6fd upstream) makes the MSI handler disable
and re-enable interrupts.  When re-enabling interrupts, we should set
the same flags as were originally set, but this changed in Linux 3.5 so
the flags are now inconsistent in 3.2.  In fact, the extra flag isn't
even defined in 3.2.  Remove the extra flag from the MSI handler.

Reported-by: Steve Conklin <steve.conklin@canonical.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/rapidio/devices/tsi721.c

index 23ef16c..84eab3f 100644 (file)
@@ -555,7 +555,7 @@ static irqreturn_t tsi721_irqhandler(int irq, void *ptr)
        /* For MSI mode re-enable device-level interrupts */
        if (priv->flags & TSI721_USING_MSI) {
                dev_int = TSI721_DEV_INT_SR2PC_CH | TSI721_DEV_INT_SRIO |
-                       TSI721_DEV_INT_SMSG_CH | TSI721_DEV_INT_BDMA_CH;
+                       TSI721_DEV_INT_SMSG_CH;
                iowrite32(dev_int, priv->regs + TSI721_DEV_INTE);
        }