workqueue: sanity check pool->cpu in wq_worker_sleeping()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 3 Jun 2014 07:33:08 +0000 (15:33 +0800)
committerTejun Heo <tj@kernel.org>
Thu, 19 Jun 2014 16:32:27 +0000 (12:32 -0400)
In theory, pool->cpu is equals to @cpu in wq_worker_sleeping() after
worker->flags is checked.

And "pool->cpu != cpu" sanity check will help us if something wrong.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c

index 4f8d72d..8474e57 100644 (file)
@@ -843,7 +843,7 @@ struct task_struct *wq_worker_sleeping(struct task_struct *task, int cpu)
        pool = worker->pool;
 
        /* this can only happen on the local cpu */
-       if (WARN_ON_ONCE(cpu != raw_smp_processor_id()))
+       if (WARN_ON_ONCE(cpu != raw_smp_processor_id() || pool->cpu != cpu))
                return NULL;
 
        /*