perf_counter: powerpc: Fix two compile warnings
authorPaul Mackerras <paulus@samba.org>
Mon, 15 Jun 2009 11:36:52 +0000 (21:36 +1000)
committerIngo Molnar <mingo@elte.hu>
Mon, 15 Jun 2009 14:12:25 +0000 (16:12 +0200)
This fixes a couple of compile warnings that crept into the powerpc
perf_counter code recently:

   CC      arch/powerpc/kernel/perf_counter.o
 arch/powerpc/kernel/perf_counter.c: In function 'record_and_restart':
 arch/powerpc/kernel/perf_counter.c:1016: warning: unused variable 'addr'
 arch/powerpc/kernel/perf_counter.c: In function 'hw_perf_counter_init':
 arch/powerpc/kernel/perf_counter.c:891: warning: 'ev' may be used uninitialized in this function

Stephen Rothwell reported this against linux-next as well.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <18998.12884.787039.22202@cargo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/powerpc/kernel/perf_counter.c

index bb20238..e6dc185 100644 (file)
@@ -913,6 +913,8 @@ const struct pmu *hw_perf_counter_init(struct perf_counter *counter)
        case PERF_TYPE_RAW:
                ev = counter->attr.config;
                break;
+       default:
+               return ERR_PTR(-EINVAL);
        }
        counter->hw.config_base = ev;
        counter->hw.idx = 0;
@@ -1013,7 +1015,7 @@ static void record_and_restart(struct perf_counter *counter, long val,
        u64 period = counter->hw.sample_period;
        s64 prev, delta, left;
        int record = 0;
-       u64 addr, mmcra, sdsync;
+       u64 mmcra, sdsync;
 
        /* we don't have to worry about interrupts here */
        prev = atomic64_read(&counter->hw.prev_count);