tracing: remove duplicate null-pointer check in skb tracepoint
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 6 Jan 2011 17:53:19 +0000 (12:53 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Sat, 8 Jan 2011 01:55:42 +0000 (20:55 -0500)
The check for NULL skb in the kfree_skb trace event is a duplicate from the
check already done in its only caller, kfree_skb(). Remove this duplicate check.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
LKML-Reference: <20110106175319.GA30610@Krystal>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: David S. Miller <davem@davemloft.net>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Zhaolei <zhaolei@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
include/trace/events/skb.h

index 75ce9d5..f10293c 100644 (file)
@@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
 
        TP_fast_assign(
                __entry->skbaddr = skb;
-               if (skb) {
-                       __entry->protocol = ntohs(skb->protocol);
-               }
+               __entry->protocol = ntohs(skb->protocol);
                __entry->location = location;
        ),