max2165: trival fix for some -Wuninitialized warning
authorDanny Kukawka <danny.kukawka@bisect.de>
Mon, 30 Jan 2012 21:00:06 +0000 (18:00 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 19 Mar 2018 18:58:24 +0000 (18:58 +0000)
commit 32d7e63c1f4f86ad18404e3f36be99c9910fae9b upstream.

Fix for some -Wuninitialized compiler warnings.

Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/common/tuners/max2165.c

index 9883617..d5773bd 100644 (file)
@@ -168,7 +168,7 @@ int fixpt_div32(u32 dividend, u32 divisor, u32 *quotient, u32 *fraction)
        int i;
 
        if (0 == divisor)
-               return -1;
+               return -EINVAL;
 
        q = dividend / divisor;
        remainder = dividend - q * divisor;
@@ -194,10 +194,13 @@ static int max2165_set_rf(struct max2165_priv *priv, u32 freq)
        u8 tf_ntch;
        u32 t;
        u32 quotient, fraction;
+       int ret;
 
        /* Set PLL divider according to RF frequency */
-       fixpt_div32(freq / 1000, priv->config->osc_clk * 1000,
-               &quotient, &fraction);
+       ret = fixpt_div32(freq / 1000, priv->config->osc_clk * 1000,
+                        &quotient, &fraction);
+       if (ret != 0)
+               return ret;
 
        /* 20-bit fraction */
        fraction >>= 12;