staging/xgifb: Remove unnecessary bitshifts in XGI_SetCRT1ModeRegs
authorPeter Huewe <peterhuewe@gmx.de>
Sun, 3 Feb 2013 21:54:37 +0000 (22:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Feb 2013 18:46:28 +0000 (10:46 -0800)
Since data can only be 0x0000, 0x0035 or 0x0048 we can simply skip the
bit shifting and masking as data & 0xFF is always equal to data and
data & 0xFF00 is always 0.
So we simply use data and 0 directly and save the assignment.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/xgifb/vb_setmode.c

index 6f366f4..1ff1178 100644 (file)
@@ -1083,10 +1083,8 @@ static void XGI_SetCRT1ModeRegs(struct xgi_hw_device_info *HwDeviceExtension,
                        data = 0x0048;
        }
 
-       data2 = data & 0x00FF;
-       xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFF, data2);
-       data2 = (data & 0xFF00) >> 8;
-       xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFC, data2);
+       xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFF, data);
+       xgifb_reg_and_or(pVBInfo->P3d4, 0x19, 0xFC, 0);
 
        if (modeflag & HalfDCLK)
                xgifb_reg_and_or(pVBInfo->P3c4, 0x01, 0xF7, 0x08);