mm: remove unused arg of set_page_dirty_balance()
authorMiklos Szeredi <mszeredi@suse.cz>
Mon, 7 Apr 2014 22:37:51 +0000 (15:37 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:35 +0000 (00:49 +0000)
commit ed6d7c8e578331cad594ee70d60e2e146b5dce7b upstream.

There's only one caller of set_page_dirty_balance() and that will call it
with page_mkwrite == 0.

The page_mkwrite argument was unused since commit b827e496c893 "mm: close
page_mkwrite races".

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/writeback.h
mm/memory.c
mm/page-writeback.c

index 7e85d45..bd214ae 100644 (file)
@@ -190,7 +190,7 @@ int write_cache_pages(struct address_space *mapping,
                      struct writeback_control *wbc, writepage_t writepage,
                      void *data);
 int do_writepages(struct address_space *mapping, struct writeback_control *wbc);
-void set_page_dirty_balance(struct page *page, int page_mkwrite);
+void set_page_dirty_balance(struct page *page);
 void writeback_set_ratelimit(void);
 void tag_pages_for_writeback(struct address_space *mapping,
                             pgoff_t start, pgoff_t end);
index e714317..fb55a97 100644 (file)
@@ -2671,7 +2671,7 @@ reuse:
                 */
                if (!page_mkwrite) {
                        wait_on_page_locked(dirty_page);
-                       set_page_dirty_balance(dirty_page, page_mkwrite);
+                       set_page_dirty_balance(dirty_page);
                }
                put_page(dirty_page);
                if (page_mkwrite) {
index d2ac057..cab99e8 100644 (file)
@@ -1202,9 +1202,9 @@ pause:
                bdi_start_background_writeback(bdi);
 }
 
-void set_page_dirty_balance(struct page *page, int page_mkwrite)
+void set_page_dirty_balance(struct page *page)
 {
-       if (set_page_dirty(page) || page_mkwrite) {
+       if (set_page_dirty(page)) {
                struct address_space *mapping = page_mapping(page);
 
                if (mapping)