[PATCH] ahci: do not mangle saved HOST_CAP while resetting controller
authorTejun Heo <htejun@gmail.com>
Tue, 12 Dec 2006 11:17:32 +0000 (20:17 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 16 Dec 2006 15:13:29 +0000 (10:13 -0500)
Do not mangle with HOST_CAP while resetting controller.  The code is
there for a historical reason.  The mangling breaks controller feature
detection and 0 PORTS_IMPL workaround code.

This problem was spotted by Manoj Kasichainula.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Manoj Kasichainula <manoj@io.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/ahci.c

index f36da48..dbae6d9 100644 (file)
@@ -645,8 +645,6 @@ static int ahci_reset_controller(void __iomem *mmio, struct pci_dev *pdev)
        u32 cap_save, impl_save, tmp;
 
        cap_save = readl(mmio + HOST_CAP);
-       cap_save &= ( (1<<28) | (1<<17) );
-       cap_save |= (1 << 27);
        impl_save = readl(mmio + HOST_PORTS_IMPL);
 
        /* global controller reset */