net/mlx4_core: Make explicit conversion to 64bit value
authorLeon Romanovsky <leonro@mellanox.com>
Mon, 28 Aug 2017 13:38:21 +0000 (16:38 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 26 Nov 2017 13:51:05 +0000 (13:51 +0000)
commit 187782eb58a89ea030731114c6ae37842a4472fe upstream.

The "lg" variable is declared as int so in all places where this variable
is used as a shift operand, the output will be int too.

This produces the following smatch warning:
drivers/net/ethernet/mellanox/mlx4/fw.c:1532 mlx4_map_cmd() warn:
should '1 << lg' be a 64 bit type?

Simple declaration of "1" to be "1ULL" will fix the issue.

Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/ethernet/mellanox/mlx4/fw.c

index 8892348..46aae5b 100644 (file)
@@ -512,7 +512,7 @@ int mlx4_map_cmd(struct mlx4_dev *dev, u16 op, struct mlx4_icm *icm, u64 virt)
                for (i = 0; i < mlx4_icm_size(&iter) >> lg; ++i) {
                        if (virt != -1) {
                                pages[nent * 2] = cpu_to_be64(virt);
                for (i = 0; i < mlx4_icm_size(&iter) >> lg; ++i) {
                        if (virt != -1) {
                                pages[nent * 2] = cpu_to_be64(virt);
-                               virt += 1 << lg;
+                               virt += 1ULL << lg;
                        }
 
                        pages[nent * 2 + 1] =
                        }
 
                        pages[nent * 2 + 1] =