HID: plantronics: remove superfluous .probe()
authorJiri Kosina <jkosina@suse.cz>
Mon, 3 Nov 2014 13:19:14 +0000 (14:19 +0100)
committerJiri Kosina <jkosina@suse.cz>
Mon, 3 Nov 2014 13:19:14 +0000 (14:19 +0100)
Remove redundanct probe() callback, as it isn't doing anything extra
that HID core wouldn't do by default.

Reported-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-plantronics.c

index 215cdbd..2180e07 100644 (file)
@@ -36,28 +36,6 @@ static int plantronics_input_mapping(struct hid_device *hdev,
        return -1;
 }
 
-static int plantronics_probe(struct hid_device *hdev,
-                            const struct hid_device_id *id)
-{
-       int ret;
-
-       ret = hid_parse(hdev);
-       if (ret) {
-               hid_err(hdev, "parse failed\n");
-               goto err;
-       }
-
-       ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
-       if (ret) {
-               hid_err(hdev, "hw start failed\n");
-               goto err;
-       }
-
-       return 0;
- err:
-       return ret;
-}
-
 static const struct hid_device_id plantronics_devices[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_PLANTRONICS, HID_ANY_ID) },
        { }
@@ -68,7 +46,6 @@ static struct hid_driver plantronics_driver = {
        .name = "plantronics",
        .id_table = plantronics_devices,
        .input_mapping = plantronics_input_mapping,
-       .probe = plantronics_probe,
 };
 module_hid_driver(plantronics_driver);