scsi: aacraid: remove redundant setting of variable c
authorColin Ian King <colin.king@canonical.com>
Fri, 5 Jan 2018 15:31:06 +0000 (15:31 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:06 +0000 (00:30 +0100)
commit 91814744646351a470f256fbcb853fb5a7229a9f upstream.

A previous commit no longer stores the contents of c, so we now have a
situation where c is being updated but the value is never read. Clean up
the code by removing the now redundant setting of variable c.

Cleans up clang warning:
drivers/scsi/aacraid/aachba.c:943:3: warning: Value stored to 'c' is
never read

Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/aacraid/aachba.c

index 7170d39..29ffc65 100644 (file)
@@ -784,11 +784,8 @@ static void setinqstr(struct aac_dev *dev, void *data, int tindex)
                while (*cp == ' ')
                        ++cp;
                /* last six chars reserved for vol type */
-               c = 0;
-               if (strlen(cp) > sizeof(str->pid)) {
-                       c = cp[sizeof(str->pid)];
+               if (strlen(cp) > sizeof(str->pid))
                        cp[sizeof(str->pid)] = '\0';
-               }
                inqstrcpy (cp, str->pid);
 
                kfree(cname);