budget-av: only use t_state if initialized
authorPaul Bolle <pebolle@tiscali.nl>
Thu, 1 Nov 2012 19:24:30 +0000 (16:24 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 19 Mar 2018 18:58:25 +0000 (18:58 +0000)
commit cb31c7487580a0cfc6eb253e604c1e51ac8eb3c8 upstream.

Building budget-av.o triggers this GCC warning:
    In file included from drivers/media/pci/ttpci/budget-av.c:44:0:
    drivers/media/dvb-frontends/tda8261_cfg.h: In function ‘tda8261_get_bandwidth’:
    drivers/media/dvb-frontends/tda8261_cfg.h:68:21: warning: ‘t_state.bandwidth’ may be used uninitialized in this function [-Wuninitialized]
Move the printk() that uses t_state.bandwith to the location where it
should be initialized to fix this.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/dvb/frontends/tda8261_cfg.h

index 1af1ee4..4671074 100644 (file)
@@ -78,7 +78,7 @@ static int tda8261_get_bandwidth(struct dvb_frontend *fe, u32 *bandwidth)
                        return err;
                }
                *bandwidth = t_state.bandwidth;
+               printk("%s: Bandwidth=%d\n", __func__, t_state.bandwidth);
        }
-       printk("%s: Bandwidth=%d\n", __func__, t_state.bandwidth);
        return 0;
 }