usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thu, 10 Mar 2016 02:30:15 +0000 (11:30 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 30 Apr 2016 22:05:21 +0000 (00:05 +0200)
commit 6490865c67825277b29638e839850882600b48ec upstream.

This patch adds a code to surely disable TX IRQ of the pipe before
starting TX DMAC transfer. Otherwise, a lot of unnecessary TX IRQs
may happen in rare cases when DMAC is used.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/renesas_usbhs/fifo.c

index 60b274a..6fb5514 100644 (file)
@@ -932,6 +932,7 @@ static int usbhsf_dma_try_pop(struct usbhs_pkt *pkt, int *is_done)
 
        pkt->trans = len;
 
+       usbhsf_tx_irq_ctrl(pipe, 0);
        tasklet_init(&fifo->tasklet,
                     usbhsf_dma_prepare_tasklet,
                     (unsigned long)pkt);