sata_sil24: Identify which card suffered IRQ status error
authorTim Small <tim@buttersideup.com>
Tue, 22 Jul 2014 13:28:00 +0000 (14:28 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 22 Jul 2014 14:08:31 +0000 (10:08 -0400)
In machines with multiple Silicon Image 3124 and/or 3132 cards, there is no
way to tell which card is the culprit when the sata_sil24 interrupt handler
gets a bad status.

Tested-by: Tim Small <tim@seoss.co.uk>
Signed-off-by: Tim Small <tim@seoss.co.uk>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_sil24.c

index 0534890..d81b20d 100644 (file)
@@ -1154,8 +1154,8 @@ static irqreturn_t sil24_interrupt(int irq, void *dev_instance)
        status = readl(host_base + HOST_IRQ_STAT);
 
        if (status == 0xffffffff) {
-               printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, "
-                      "PCI fault or device removal?\n");
+               dev_err(host->dev, "IRQ status == 0xffffffff, "
+                       "PCI fault or device removal?\n");
                goto out;
        }