sparc: PCI: Fix incorrect address calculation of PCI Bridge windows on Simba-bridges
authoroftedal <oftedal@gmail.com>
Fri, 18 Oct 2013 20:28:29 +0000 (22:28 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Apr 2014 15:23:18 +0000 (16:23 +0100)
[ Upstream commit 557fc5873ef178c4b3e1e36a42db547ecdc43f9b ]

The SIMBA APB Bridges lacks the 'ranges' of-property describing the
PCI I/O and memory areas located beneath the bridge. Faking this
information has been performed by reading range registers in the
APB bridge, and calculating the corresponding areas.

In commit 01f94c4a6ced476ce69b895426fc29bfc48c69bd
("Fix sabre pci controllers with new probing scheme.") a bug was
introduced into this calculation, causing the PCI memory areas
to be calculated incorrectly: The shift size was set to be
identical for I/O and MEM ranges, which is incorrect.

This patch set the shift size of the MEM range back to the
value used before 01f94c4a6ced476ce69b895426fc29bfc48c69bd.

Signed-off-by: Kjetil Oftedal <oftedal@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/sparc/kernel/pci.c

index 31111e3..656b5b6 100644 (file)
@@ -487,8 +487,8 @@ static void __devinit apb_fake_ranges(struct pci_dev *dev,
        pci_read_config_byte(dev, APB_MEM_ADDRESS_MAP, &map);
        apb_calc_first_last(map, &first, &last);
        res = bus->resource[1];
-       res->start = (first << 21);
-       res->end = (last << 21) + ((1 << 21) - 1);
+       res->start = (first << 29);
+       res->end = (last << 29) + ((1 << 29) - 1);
        res->flags = IORESOURCE_MEM;
        pci_resource_adjust(res, &pbm->mem_space);
 }