drm/vmwgfx: Fix nasty write past alloced memory area
authorThomas Hellstrom <thellstrom@vmware.com>
Fri, 1 Jun 2012 13:48:04 +0000 (15:48 +0200)
committerDave Airlie <airlied@redhat.com>
Fri, 1 Jun 2012 16:00:20 +0000 (17:00 +0100)
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c

index 51c9ba5..21ee782 100644 (file)
@@ -66,7 +66,7 @@ static int vmw_gmr2_bind(struct vmw_private *dev_priv,
        cmd += sizeof(remap_cmd) / sizeof(uint32);
 
        for (i = 0; i < num_pages; ++i) {
-               if (VMW_PPN_SIZE > 4)
+               if (VMW_PPN_SIZE <= 4)
                        *cmd = page_to_pfn(*pages++);
                else
                        *((uint64_t *)cmd) = page_to_pfn(*pages++);