power: reset: ltc2952: drop empty suspend/resume functions
authorFrans Klaver <frans.klaver@xsens.com>
Wed, 14 Jan 2015 08:15:40 +0000 (09:15 +0100)
committerSebastian Reichel <sre@kernel.org>
Tue, 20 Jan 2015 12:58:29 +0000 (13:58 +0100)
Documentation/SubmittingDrivers suggests these be implemented even when
they do nothing. On the other hand, the platform code calls these
functions 'legacy'. Suspend and resume operations should go into a
pm_ops structure, pointed at by the driver's pm field. This approach
would lead to a lot of boiler plate, while achieving nothing. Drop the
functions instead.

Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/reset/ltc2952-poweroff.c

index 8c936ed..d299487 100644 (file)
@@ -184,17 +184,6 @@ static void ltc2952_poweroff_kill(void)
        gpiod_set_value(ltc2952_data->gpio_kill, 1);
 }
 
-static int ltc2952_poweroff_suspend(struct platform_device *pdev,
-       pm_message_t state)
-{
-       return -ENOSYS;
-}
-
-static int ltc2952_poweroff_resume(struct platform_device *pdev)
-{
-       return -ENOSYS;
-}
-
 static void ltc2952_poweroff_default(struct ltc2952_poweroff *data)
 {
        data->wde_interval = ktime_set(0, 300L*1E6L);
@@ -322,8 +311,6 @@ static struct platform_driver ltc2952_poweroff_driver = {
                .name = "ltc2952-poweroff",
                .of_match_table = of_ltc2952_poweroff_match,
        },
-       .suspend = ltc2952_poweroff_suspend,
-       .resume = ltc2952_poweroff_resume,
 };
 
 module_platform_driver(ltc2952_poweroff_driver);