kernel/signal.c: stop info leak via the tkill and the tgkill syscalls
authorEmese Revfy <re.emese@gmail.com>
Wed, 17 Apr 2013 22:58:36 +0000 (15:58 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 25 Apr 2013 19:25:42 +0000 (20:25 +0100)
commitffe1341edbe2878134f3083625d5c916670d0fca
treef311f54950c0617b74dcfe06bd31d2d6f0a4c3d8
parent7ec0873ac3cba439ee9846e8cbc332cac0e6c1f5
kernel/signal.c: stop info leak via the tkill and the tgkill syscalls

commit b9e146d8eb3b9ecae5086d373b50fa0c1f3e7f0f upstream.

This fixes a kernel memory contents leak via the tkill and tgkill syscalls
for compat processes.

This is visible in the siginfo_t->_sifields._rt.si_sigval.sival_ptr field
when handling signals delivered from tkill.

The place of the infoleak:

int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
{
        ...
        put_user_ex(ptr_to_compat(from->si_ptr), &to->si_ptr);
        ...
}

Signed-off-by: Emese Revfy <re.emese@gmail.com>
Reviewed-by: PaX Team <pageexec@freemail.hu>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Serge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/signal.c